Skip to content

log widget null error only when widget is supposed to be rendered #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinbluehweis merged 1 commit into from
Sep 25, 2025
Merged

log widget null error only when widget is supposed to be rendered #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...rs.base/src/main/java/org/eclipse/fx/ui/workbench/renderers/base/BaseToolBarRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ public void run() {
public void doProcessContent(MToolBar element) {
WToolBar<N> toolbar = getWidget(element);
if( toolbar == null ) {
getLogger().error("Could not find widget for '"+element+"'"); //$NON-NLS-1$//$NON-NLS-2$
if (element.isToBeRendered()) {
getLogger().error("Could not find widget for '" + element + "'"); //$NON-NLS-1$//$NON-NLS-2$
}
return;
}
for (MToolBarElement item : element.getChildren()) {
Expand All @@ -79,15 +81,17 @@ public void do_childRendered(MToolBar parentElement, MUIElement element) {

WToolBar<N> toolbar = getWidget(parentElement);
if( toolbar == null ) {
getLogger().error("Could not find widget for '"+parentElement+"'"); //$NON-NLS-1$ //$NON-NLS-2$
if (parentElement.isToBeRendered()) {
getLogger().error("Could not find widget for '" + parentElement + "'"); //$NON-NLS-1$ //$NON-NLS-2$
}
return;
}
int idx = getRenderedIndex(parentElement, element);
@SuppressWarnings("unchecked")
WWidget<MToolBarElement> widget = (WWidget<MToolBarElement>) element.getWidget();
if( widget != null ) {
toolbar.addChild(idx, widget);
} else {
} else if (element.isToBeRendered()) {
this.logger.error("The widget for element '"+element+"' should not be null."); //$NON-NLS-1$//$NON-NLS-2$
}

Expand Down
Loading