This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Bug 531986 - Change isQueryResult logic #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all arrays were treated as OSLC Query results unless the array type was explicitly marked with @OslcNotQueryResult annotation. This prevented from returning arrays of mixed-typed OSLC resources (as Object[] or IResource[]) because there is no way to annotate those classes accordingly. From now on, only arrays returned from JAX-RS methods annotated with @OslcQueryCapability will be automatically treated as OSLC Query results (again, unless the returned array type is annotated with the @OslcNotQueryResult). Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Contributor
Author
|
Requires #22 to be fixed first. |
Contributor
Author
|
@jadelkhoury @jamsden please review |
jamsden
reviewed
Apr 23, 2019
jamsden
left a comment
jamsden
left a comment
There was a problem hiding this comment.
What are the implications of this change to existing server and client implementations?
Contributor
Author
|
This will have impact on the services that:
We expect the number of services impacted to be ZERO. |
Contributor
Author
|
And no implications for the clients at all |
jadelkhoury
approved these changes
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all arrays were treated as OSLC Query results unless the
array type was explicitly marked with @OslcNotQueryResult annotation.
This prevented from returning arrays of mixed-typed OSLC resources (as
Object[] or IResource[]) because there is no way to annotate those
classes accordingly.
From now on, only arrays returned from JAX-RS methods annotated with
@OslcQueryCapability will be automatically treated as OSLC Query results
(again, unless the returned array type is annotated with the
@OslcNotQueryResult).