This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Detect Lyo URI and correctly pass POST parameters#36
Open
berezovskyi wants to merge 5 commits intomasterfrom
Open
Detect Lyo URI and correctly pass POST parameters#36berezovskyi wants to merge 5 commits intomasterfrom
berezovskyi wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Contributor
|
I don't believe we have migrated lyo.server to Jax-rs 2.0. So maybe it's about time. |
Contributor
Author
Contributor
|
I take it back then :-) |
berezovskyi
commented
Dec 12, 2019
| } | ||
| } | ||
|
|
||
| public static class OAuthServletRequestWrapper extends HttpServletRequestWrapper { |
Contributor
Author
There was a problem hiding this comment.
add comment why to do this
If the parameter data was sent in the request body, such as occurs with an HTTP POST request, then reading the body directly via getInputStream() or getReader() can interfere with the execution of this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
OAuthRequest(HttpServletRequest request, boolean detectLyoURI))OAuthRequest.OAuthServletRequestWrapperclass andOAuthService::doPostRequestTokenwhere its intended use is shown)This is a pretty major change and I am surprised how it worked before. Apparently, Wink had some extra behaviour that allowed for the input stream to be read multiple times.