Skip to content

Conversation

@jadelkhoury
Copy link
Contributor

@jadelkhoury jadelkhoury commented Nov 26, 2021

Signed-off-by: Jad El-khoury jad.el.khoury@scania.com

Description

Add XMLLiteral well-formedness helper to Lyo

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Copy link
Contributor

@berezovskyi berezovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe to add to Lyo 4.1.

Note that if users manually edit XML and use rdf:datatype instead of rdf:parseType, you need to unescape the string before the check: https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringEscapeUtils.html#unescapeXml-java.lang.String-. This was not added to the code because this situation can only arise if you are editing RDF/XML by hand,

@berezovskyi berezovskyi force-pushed the xml-well-formed-validator branch from 96c0526 to 3bbf942 Compare February 15, 2022 23:20
@berezovskyi berezovskyi force-pushed the xml-well-formed-validator branch 2 times, most recently from 709c0cf to f8b0731 Compare April 9, 2022 16:58
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@berezovskyi berezovskyi added this to the 5.1 milestone May 9, 2022
@berezovskyi berezovskyi force-pushed the xml-well-formed-validator branch from f8b0731 to a67c37a Compare April 14, 2023 22:15
@github-actions github-actions bot force-pushed the xml-well-formed-validator branch 6 times, most recently from 0cdf4b8 to 17f0639 Compare May 2, 2023 07:43
@github-actions github-actions bot force-pushed the xml-well-formed-validator branch 2 times, most recently from 99df3c6 to 5b1c2ee Compare May 24, 2023 07:43
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@github-actions github-actions bot force-pushed the xml-well-formed-validator branch from 5b1c2ee to e4c76fe Compare June 13, 2023 07:43
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi
Copy link
Contributor

@jadelkhoury I am targeting this PR for Lyo 5.1 unless you have a good reason not to do that.

@Jad-el-khoury
Copy link
Contributor

Sounds good to me. Is tehre a reason we kept it open for so long? is it safe to merge now?

@berezovskyi
Copy link
Contributor

berezovskyi commented Jun 13, 2023

I think it was connected to #214, which may not be as safe to merge as this helper.

The main reason for the delay is that this helper is mainly useful for Jazz applications that misuse the XMLLiteral type to return what should be a regular strings and I don't deal with these Jazz quirks daily. And so it fell off my radar.

Tests passed on all JDKs, merging.

@berezovskyi berezovskyi merged commit d5b81c7 into master Jun 13, 2023
@berezovskyi berezovskyi deleted the xml-well-formed-validator branch June 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants