-
Notifications
You must be signed in to change notification settings - Fork 18
Add XMLLiteral well-formedness helper to Lyo #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
berezovskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be safe to add to Lyo 4.1.
Note that if users manually edit XML and use rdf:datatype instead of rdf:parseType, you need to unescape the string before the check: https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringEscapeUtils.html#unescapeXml-java.lang.String-. This was not added to the code because this situation can only arise if you are editing RDF/XML by hand,
96c0526 to
3bbf942
Compare
709c0cf to
f8b0731
Compare
|
SonarCloud Quality Gate failed. |
f8b0731 to
a67c37a
Compare
0cdf4b8 to
17f0639
Compare
99df3c6 to
5b1c2ee
Compare
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
5b1c2ee to
e4c76fe
Compare
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
|
@jadelkhoury I am targeting this PR for Lyo 5.1 unless you have a good reason not to do that. |
|
Sounds good to me. Is tehre a reason we kept it open for so long? is it safe to merge now? |
|
I think it was connected to #214, which may not be as safe to merge as this helper. The main reason for the delay is that this helper is mainly useful for Jazz applications that misuse the XMLLiteral type to return what should be a regular strings and I don't deal with these Jazz quirks daily. And so it fell off my radar. Tests passed on all JDKs, merging. |








Signed-off-by: Jad El-khoury jad.el.khoury@scania.com
Description
Add XMLLiteral well-formedness helper to Lyo
Checklist