Doip server initial code by VinaykumarRS1995 · Pull Request #4 · eclipse-opensovd/uds2sovd-proxy

VinaykumarRS1995 · 2026-02-25T12:51:36Z

Summary

Checklist

I have tested my changes locally
I have added or updated documentation
I have linked related issues or discussions
I have added or updated tests

- Renamed hearder_parser.rs to header_parser.rs (typo fix) - Added unit tests for header parsing - Updated MAX_DOIP_MESSAGE_SIZE to 4MB

arvindr19 · 2026-02-26T04:19:44Z

Is this code supposed to build? When I ran cargo check and cargo build, I encountered some errors. IMO, code should build successfully.

VinaykumarRS1995 · 2026-02-26T09:43:47Z

Is this code supposed to build? When I ran cargo check and cargo build, I encountered some errors. IMO, code should build successfully.

build is successful is now.

arvindr19 · 2026-02-26T10:03:37Z

src/doip/diagnostic_message.rs

+    pub fn parse(payload: &[u8]) -> Result<Self, Error> {
+        let header: [u8; 4] =
+            payload
+                .get(..4)


magic number? other places I could see used const
Not just here, please check below ones

Fixed all magic numbers across the codebase (named constants , protocol versions, and message sizes). Will push in the next commit.

arvindr19 · 2026-02-26T10:10:36Z

fix minor formatting inconsistencies
toml = "0.9.11+spec-1.1.0" causing warning, why not toml = "0.9" instead?

arvindr19

Only header_parser.rs has any tracing at all. Every other file has no tracing.

arvindr19 · 2026-02-26T13:50:38Z

src/doip/header.rs

+/// when the `DoIP` entity cannot process a received message due to header-level issues.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[repr(u8)]
+pub enum GenericNackCode {


same defined in errors.rs
why so?

Fixed , re-exported now

arvindr19 · 2026-02-26T13:52:56Z

src/doip/routing_activation.rs

+// Response codes per ISO 13400-2:2019 Table 25
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[repr(u8)]
+pub enum ResponseCode {


duplicates in error.rs

Fixed , re-exported now.

arvindr19 · 2026-02-26T13:54:44Z

src/doip/diagnostic_message.rs

+// Diagnostic message negative ack codes per ISO 13400-2:2019 Table 28
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[repr(u8)]
+pub enum NackCode {


duplicates in error.rs

arvindr19 · 2026-02-26T15:38:23Z

src/doip/header_parser.rs

+                inverse_version: DEFAULT_PROTOCOL_VERSION_INV,
+                payload_type: payload_type as u16,
+                payload_length: u32::try_from(payload.len())
+                    .expect("DoIP payload exceeds u32::MAX (protocol limit is 4MB)"),


lib should never panic, return Result instead

Fixed, retruns Result now.

darkwisebear

I didn't go into details yet, but from what I see there are some general things that need cleanup before I will do that:

Consolidate error types and use thiserror everywhere.
Introduce a trait for message types and use everywhere
Deduplicate common parsing code

darkwisebear · 2026-02-26T20:04:03Z

src/doip/alive_check.rs

+use bytes::{BufMut, Bytes, BytesMut};
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum Error {


This crate references thiserror. You could use it to declare this error in a more convenient way.

darkwisebear · 2026-02-26T20:10:58Z

src/doip/vehicle_id.rs

+use bytes::{BufMut, Bytes, BytesMut};
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum Error {


A similar definition exists in alive_check.rs. Imo we should have a common definition of an error type for the entire module.

moved to mod.rs and shared across

darkwisebear · 2026-02-26T20:13:08Z

src/doip/vehicle_id.rs

+
+// Vehicle Identification Request (0x0001) - no payload
+#[derive(Debug, Clone, PartialEq, Eq, Default)]
+pub struct Request;


The shape of this module is very similar to that of alive_check.rs. I think there should be a trait for message types so that there is an impl Request for VehicleIdRequest or the like.

trait defined

darkwisebear · 2026-02-26T20:37:18Z

src/doip/vehicle_id.rs

+        let eid: [u8; 6] = payload
+            .get(..Self::LEN)
+            .and_then(|s| s.try_into().ok())
+            .ok_or(Error::PayloadTooShort {
+                expected: Self::LEN,
+                actual: payload.len(),
+            })?;


Such code could be factored out, as there is similar code also in alive_check.rs. I think there should be a submodule messages with common definitions and then types for each message.

darkwisebear · 2026-02-26T20:40:26Z

src/doip/header_parser.rs

+
+impl PayloadType {
+    #[must_use]
+    pub fn from_u16(value: u16) -> Option<Self> {


Why not impl TryFrom<u16> for PayloadType? This is more canonical than such a custom function.

yes, updated.

darkwisebear · 2026-02-26T20:44:15Z

src/server/config.rs

+            let bind = server
+                .bind_address
+                .as_deref()
+                .unwrap_or(DEFAULT_BIND_ADDRESS);


serde allows for specifying defaults inside the type definition. This would save you a lot of code that of the scheme "if value { copy } else { use default }".

Yes , it is updated now

arvindr19 · 2026-02-27T05:25:17Z

src/doip/alive_check.rs

@@ -0,0 +1,144 @@
+/*
+ * Copyright (c) 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)


year should be 2026, please check all the license headers

updated where needed

- Consolidate errors into DoipError; add TryFrom<u8> on all enums - Strongly type activation_type field (ActivationType, not u8) - Add DoipParseable / DoipSerializable traits + DoipPayload dispatch enum - Override serialized_len() on all impls; fix array size magic numbers - Make ParseError pub(crate); add serde(default), tracing

arvindr19 · 2026-03-02T06:23:08Z

Please run cargo fmt --check; it currently fails. Once the CI workflow PR is merged, this PR will need to be reworked, so it’s better to fix it beforehand.

lh-sag

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?

Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

lh-sag · 2026-03-04T06:35:06Z

Cargo.toml

+[dependencies]
+# Async runtime
+tokio = { version = "1.35", features = ["full"] }
+tokio-util = { version = "0.7", features = ["codec"] }
+
+# Serialization
+serde = { version = "1.0", features = ["derive"] }
+toml = "0.9"
+
+# Logging
+tracing = "0.1"
+tracing-subscriber = { version = "0.3", features = ["env-filter"] }
+
+# Error handling
+thiserror = "2.0"
+anyhow = "1.0"
+
+# Data structures
+bytes = "1.0"
+dashmap = "6.0"
+parking_lot = "0.12"
+
+# Utilities
+uuid = { version = "1.6", features = ["v4"] }
+clap = { version = "4.4", features = ["derive"] }


Always use default-features = false and explicitly add feature as needed. This reduced sbom and binary size often significantly.

lh-sag · 2026-03-04T06:38:57Z

src/uds/mod.rs

+// #[cfg(any(test, feature = "test-handlers"))]
+// pub mod dummy_handler;


Please remove commented out code.

lh-sag · 2026-03-04T06:45:54Z

src/server/config.rs

+    fn parse_vin(s: &str) -> anyhow::Result<[u8; 17]> {
+        let bytes = s.as_bytes();
+        if bytes.len() != 17 {
+            anyhow::bail!("VIN must be exactly 17 characters");


Optional: I would rather return a proper error type than a string.

lh-sag · 2026-03-04T07:02:51Z

Cargo.toml

+dashmap = "6.0"
+parking_lot = "0.12"


Can you please double check that all crates are used/referenced in your code?

alexmohr · 2026-03-04T10:16:43Z

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?
* https://github.com/samp-reston/doip-definitions

* https://github.com/samp-reston/doip-codec

* https://github.com/samp-reston/doip-sockets

* https://github.com/samp-reston/doip-server
Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

We're only using codec and definitions in the CDA as we had some issues with sockets. But using codecs and definitions would already prevent re-implemeting some things here. The sockets connections can be re-used from CDA. Currently both doip libraries we use are forked by @theswiftfox. I believe it would be a good idea to use her fork as a base to officially provide an eclipse fork we use in all of our projects.

- Split header_parser.rs into header.rs + codec.rs - Merge ParseError into DoipError (single error type) - Add parse_fixed_slice helper, remove duplicated parse patterns - Add DoipParseable / DoipSerializable traits - Make struct fields private, add public getters - Set default-features = false on all dependencies - Trim tokio features to io-util only - Remove dead test-handlers feature from Cargo.toml

floroks · 2026-03-05T08:26:34Z

I believe it would be a good idea to use her fork as a base to officially provide an eclipse fork we use in all of our projects.

As we've also run into some issues with the original code, I think we need should fork them into the eclipse-opensovd repo, so we can adapt them quickly to our needs. I'll put it on the agenda for the next architecture board.

VinaykumarRS1995 added 4 commits February 25, 2026 16:25

feat(doip): implement header parsing with tokio codec

f7cf8a0

test(doip): add unit tests for header_parser

77b34a5

- Renamed hearder_parser.rs to header_parser.rs (typo fix) - Added unit tests for header parsing - Updated MAX_DOIP_MESSAGE_SIZE to 4MB

feat(error): add DoIP error types and NRC codes

fc3388a

feat(uds): add UdsHandler trait for pluggable backends

1caf4c0

VinaykumarRS1995 force-pushed the doip-server-initial branch 2 times, most recently from a11f029 to c674ff3 Compare February 26, 2026 09:40

arvindr19 reviewed Feb 26, 2026

View reviewed changes

darkwisebear reviewed Feb 26, 2026

View reviewed changes

arvindr19 reviewed Feb 27, 2026

View reviewed changes

VinaykumarRS1995 force-pushed the doip-server-initial branch from c674ff3 to 81e9ff5 Compare February 27, 2026 07:13

VinaykumarRS1995 force-pushed the doip-server-initial branch from 81e9ff5 to 9fa0c6e Compare March 2, 2026 05:49

VinaykumarRS1995 marked this pull request as ready for review March 2, 2026 09:23

VinaykumarRS1995 requested a review from darkwisebear March 2, 2026 09:23

style: apply cargo fmt

999d8bc

lh-sag requested review from a team and removed request for darkwisebear March 4, 2026 06:32

lh-sag reviewed Mar 4, 2026

View reviewed changes

		@@ -0,0 +1,144 @@
		/*
		* Copyright (c) 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS)

		// #[cfg(any(test, feature = "test-handlers"))]
		// pub mod dummy_handler;

		dashmap = "6.0"
		parking_lot = "0.12"

Conversation

VinaykumarRS1995 commented Feb 25, 2026

Summary

Checklist

Uh oh!

arvindr19 commented Feb 26, 2026

Uh oh!

VinaykumarRS1995 commented Feb 26, 2026

Uh oh!

arvindr19 Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arvindr19 commented Feb 26, 2026

Uh oh!

arvindr19 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darkwisebear left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arvindr19 commented Mar 2, 2026

Uh oh!

lh-sag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexmohr commented Mar 4, 2026

Uh oh!

floroks commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

arvindr19 Feb 26, 2026 •

edited

Loading

floroks commented Mar 5, 2026 •

edited

Loading