Fix: ensure that /vscode/gallery/<namespace>/<extension>/latest only returns the latest versions#1791
Merged
Fix: ensure that /vscode/gallery/<namespace>/<extension>/latest only returns the latest versions#1791
/vscode/gallery/<namespace>/<extension>/latest only returns the latest versions#1791Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
The DB query to retrieve the latest version grouped by target platform has been sketched with the help of Claude Code |
netomi
added
the
snapshot
…latform only (including preRelease versions)
netomi
force-pushed
the
fix-latest-endpoint
branch
from
ac47aa4 to
71c20b8
Compare
netomi
changed the title
/vscode/gallery/<namespace>/<extension>/latest only return the latest versions/vscode/gallery/<namespace>/<extension>/latest only returns the latest versions
Contributor
Author
|
tested it locally with a copy of the production db to check performance and correctness of the results. All looks good from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1779.
This PR includes the following changes:
findLatestVersionByTargetPlatformmethod that returns the latest version per target platform/vscode/gallery/{namespace}/{extension}/latestendpoint to return the latest version per platform only, this includes both preRelease and regular versionsFurthermore, the result from the
latestendpoint is cached and invalidated if anything changes for the extension in question. TheVersionService.getLatestByTargetPlatformis also cached in preparation of changes toextensionquery.