Ensure products specifying installSources true really include sources #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the `<installSources>` configuration from the profile to the plugin management section. - Specify `<includeAllSources>` for the tycho-p2-repository-plugin and use the same install-sources property as used with `<installSources>` for the tycho-p2-director-plugin. - Introduce a `single-env` profile to build only for the host environment which is useful building locally; document that in the README.md. - Remove the build-helper-maven-plugin regex-property goal because no matches are ever found because eclipse-tycho/tycho#3725 is now fixed. - Specify the IU property org.eclipse.update.install.sources=true for all the products that specify install-sources=true so that Oomph's product catalog generator can generate an p2 director task that installs source bundles.
Contributor
Author
|
FYI @iloveeclipse This is the full set of changes. The following build will produce new results (in about 3 hours) that I can use to verify that the changes work as expect based on having run the Tycho locally first: |
Black magic :-) |
Contributor
Author
|
With the help of @laeubi, the white magician. 🪄 🧙♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<installSources>configuration from the profile to the plugin management section.<includeAllSources>for the tycho-p2-repository-plugin and use the same install-sources property as used with<installSources>for the tycho-p2-director-plugin.single-envprofile to build only for the host environment which is useful building locally; document that in the README.md.[tycho-4.0.x] TargetPlatformFactoryImpl.gatherP2InfUnits should use artifact version eclipse-tycho/tycho#3725 is now fixed.