Skip to content

Fix include paths for static_reflection_with_serialization headers #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix include paths for static_reflection_with_serialization headers #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5806e6
Fix include paths for static_reflection_with_serialization headers
pypingou Nov 3, 2025
b406a84
Fix Bazel include path mismatch for static_reflection_with_serialization
pypingou Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions score/json/json_serializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

#include "score/result/result.h"

#include <static_reflection_with_serialization/visitor/visit.h>
#include <static_reflection_with_serialization/visitor/visit_as_struct.h>
#include <visitor/visit.h>
#include <visitor/visit_as_struct.h>

#include <cstdint>
#include <optional>
Expand Down
4 changes: 2 additions & 2 deletions score/json/json_serializer_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
********************************************************************************/
#include "score/json/json_serializer.h"

#include <static_reflection_with_serialization/visitor/visit.h>
#include <static_reflection_with_serialization/visitor/visit_as_struct.h>
#include <visitor/visit.h>
#include <visitor/visit_as_struct.h>

#include <gmock/gmock-matchers.h>
#include <gtest/gtest.h>
Expand Down
6 changes: 3 additions & 3 deletions score/mw/log/detail/file_logging/dlt_message_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
#include "score/mw/log/detail/file_logging/svp_time.h"
#include "score/mw/log/log_level.h"

#include "static_reflection_with_serialization/serialization/for_logging.h"
#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "serialization/for_logging.h"
#include "visitor/visit.h"
Copy link
Contributor

@bilelmoussaoui bilelmoussaoui Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some use #include <visitor/visit.h>, some are like this ^. I would make them consistent.

Copy link
Author

@pypingou pypingou Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the looks of it, it looks like claude kept the style that was used in each file.

I'm fine making them consistent but I'd wait to hear from a maintainer what are their preferred style :)

Copy link
Author

@pypingou pypingou Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, claude is saying:

  The C++ Include Convention:

  Angle brackets < > are typically used for:
  - System headers (standard library)
  - External library headers
  - Headers from separate packages/modules

  Quotes " " are typically used for:
  - Project-local headers
  - Headers in the same module/component
  - Internal implementation headers

And thus suggests we make them all use "" instead of <>

#include "visitor/visit_as_struct.h"

#include <arpa/inet.h>
#include <chrono>
Expand Down
2 changes: 1 addition & 1 deletion score/mw/log/detail/log_entry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#include "score/mw/log/detail/logging_identifier.h"
#include "score/mw/log/log_level.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit_as_struct.h"

#include <vector>

Expand Down
2 changes: 1 addition & 1 deletion score/mw/log/detail/log_entry_deserialize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#include "score/mw/log/detail/logging_identifier.h"
#include "score/mw/log/log_level.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit_as_struct.h"

#include <score/span.hpp>

Expand Down
2 changes: 1 addition & 1 deletion score/mw/log/detail/logging_identifier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#include <string_view>

#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit_as_struct.h"

#include <array>
#include <functional>
Expand Down
1 change: 0 additions & 1 deletion score/static_reflection_with_serialization/serialization/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ cc_library(
"include/serialization/visit_type_traits.h",
],
features = _compiler_warning_features,
include_prefix = "static_reflection_with_serialization",
strip_include_prefix = "include",
tags = ["FFI"],
visibility = [
Expand Down
2 changes: 1 addition & 1 deletion ...atic_reflection_with_serialization/serialization/include/serialization/skip_deserialize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#ifndef SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_SKIP_DESERIALIZE_H
#define SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_SKIP_DESERIALIZE_H

#include "static_reflection_with_serialization/serialization/for_logging.h"
#include "serialization/for_logging.h"

namespace score
{
Expand Down
8 changes: 4 additions & 4 deletions ...tatic_reflection_with_serialization/serialization/include/serialization/visit_serialize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
#ifndef SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_VISIT_SERIALIZE_H
#define SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_VISIT_SERIALIZE_H

#include "static_reflection_with_serialization/serialization/visit_size.h"
#include "static_reflection_with_serialization/serialization/visit_type_traits.h"
#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "serialization/visit_size.h"
#include "serialization/visit_type_traits.h"
#include "visitor/visit.h"
#include "visitor/visit_as_struct.h"

#include "score/assert.hpp"
#include "score/optional.hpp"
Expand Down
6 changes: 3 additions & 3 deletions score/static_reflection_with_serialization/serialization/include/serialization/visit_size.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#ifndef SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_VISIT_SIZE_H
#define SCORE_COMMON_SERIALIZATION_INCLUDE_SERIALIZATION_VISIT_SIZE_H

#include "static_reflection_with_serialization/serialization/visit_type_traits.h"
#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "serialization/visit_type_traits.h"
#include "visitor/visit.h"
#include "visitor/visit_as_struct.h"

#include "score/assert.hpp"
#include <cstdint>
Expand Down
4 changes: 2 additions & 2 deletions score/static_reflection_with_serialization/serialization/test/ut/test_serializer_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/serialization/for_logging.h"
#include "static_reflection_with_serialization/serialization/visit_serialize.h"
#include "serialization/for_logging.h"
#include "serialization/visit_serialize.h"
#include "visitor_test_types.h"

#include <array>
Expand Down
6 changes: 3 additions & 3 deletions score/static_reflection_with_serialization/serialization/test/ut/test_size_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/serialization/visit_serialize.h"
#include "static_reflection_with_serialization/serialization/visit_size.h"
#include "static_reflection_with_serialization/serialization/visit_type_traits.h"
#include "serialization/visit_serialize.h"
#include "serialization/visit_size.h"
#include "serialization/visit_type_traits.h"
#include "visitor_test_types.h"

#include <gtest/gtest.h>
Expand Down
2 changes: 1 addition & 1 deletion score/static_reflection_with_serialization/serialization/test/ut/test_skip_deserialize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/serialization/skip_deserialize.h"
#include "serialization/skip_deserialize.h"

#include <type_traits>

Expand Down
2 changes: 1 addition & 1 deletion ...e/static_reflection_with_serialization/serialization/test/ut/test_visitor_type_traits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/serialization/visit_type_traits.h"
#include "serialization/visit_type_traits.h"
#include "visitor_test_types.h"

#include <gtest/gtest.h>
Expand Down
1 change: 0 additions & 1 deletion score/static_reflection_with_serialization/visitor/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ cc_library(
"include/visitor/visit_as_struct.h",
],
features = _compiler_warning_features,
include_prefix = "static_reflection_with_serialization",
strip_include_prefix = "include",
tags = ["FFI"],
visibility = [
Expand Down
4 changes: 2 additions & 2 deletions ...ic_reflection_with_serialization/visitor/examples/ostream/include/visitor/visit_ostream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
#ifndef SCORE_COMMON_VISITOR_EXAMPLES_OSTREAM_INCLUDE_VISITOR_VISIT_OSTREAM_H
#define SCORE_COMMON_VISITOR_EXAMPLES_OSTREAM_INCLUDE_VISITOR_VISIT_OSTREAM_H

#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit.h"
#include "visitor/visit_as_struct.h"

#include <ostream>
#include <tuple>
Expand Down
2 changes: 1 addition & 1 deletion ...c_reflection_with_serialization/visitor/examples/ostream/test/ut/test_ostream_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/visitor/visit_ostream.h"
#include "visitor/visit_ostream.h"

#include "gmock/gmock.h"
#include "gtest/gtest.h"
Expand Down
4 changes: 2 additions & 2 deletions score/static_reflection_with_serialization/visitor/test/ut/test_detail.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit.h"
#include "visitor/visit_as_struct.h"

#include "gmock/gmock.h"
#include "gtest/gtest.h"
Expand Down
4 changes: 2 additions & 2 deletions score/static_reflection_with_serialization/visitor/test/ut/test_struct_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/visitor/visit.h"
#include "static_reflection_with_serialization/visitor/visit_as_struct.h"
#include "visitor/visit.h"
#include "visitor/visit_as_struct.h"

#include "gmock/gmock.h"
#include "gtest/gtest.h"
Expand Down
2 changes: 1 addition & 1 deletion score/static_reflection_with_serialization/visitor/test/ut/test_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "static_reflection_with_serialization/visitor/visit.h"
#include "visitor/visit.h"

#include "gmock/gmock.h"
#include "gtest/gtest.h"
Expand Down