Skip to content

Conversation

@skarlsson
Copy link

  • adds multiple toolchains support
  • adds arm64 from toolchains_gcc_packages

Copy link
Member

@nradakovic nradakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation is soon to be deprecated and due to that we need to move it to:
https://github.com/bazelbuild/rules_cc/tree/main/examples/rule_based_toolchain

],
visibility = ["//visibility:public"],
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have platform repository which we need to reuse for platform definitions. It's still not released, but that's just matter of adding it to S-CORE Bazel Registry.
Bazel Platform repo: https://github.com/eclipse-score/bazel_platforms

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skarlsson Whats the state of that pull request? That would be really great to have it in. Can you please fix the comments especially the platforms. Release is already there bazel_dep(name = "score_bazel_platforms", version = "0.0.2")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the earlier comment as a hint to wait until the you had a new implementation in place and I thought to give it a try again at a later time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request - at the time it was done worked and I had a working arm64 baselibs on top of that - but I found it inefficient to have so many local forks so I decided to wait

Added build_file override capability - Allows custom BUILD files for non-standard GCC structures
Removed unused template files - Cleaned up the toolchain/third_party directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants