fix: handle notification timeout correctly when set to 0 #16849
+137
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix timeout logic to properly handle explicit timeout of 0 - Change condition from falsy check to undefined check to preserve 0 value if set explicitly - Add unit tests for getTimeout method covering various timeout scenarios - Add sample commands demonstrating persistent and vanishing notifications Contributed on behalf of STMicroelectronics
eneufeld
approved these changes
Jan 22, 2026
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Sample Persistent Notification(No Timeout)Sample Vanishing Notification(500ms Timeout)Test Positive Integer(default timeout: 30000ms, unless overridden in the settingsnotification.timeout)Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers