feat: handle priority for golden records from the orchestrator #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing' into feat-priority-based-record-processing
Contributor
Author
|
@nicoprow @SujitMBRDI I've raised this PR just to get some feedback. It's still a work in progress, so feel free to share your thoughts! |
nicoprow
reviewed
Dec 20, 2024
Contributor
nicoprow
left a comment
nicoprow
left a comment
There was a problem hiding this comment.
I think the solution with an OriginID is problematic here.
- Can we not replace the origin-ID with the the tenant BPNL. Each Gate knows already its tenant and even can be multi-tenant in the case of the Portal. This way we do not need to introduce another identifier
- Now, each task is assigned with the origin-ID in the Orchestrator. This makes it exoplicit which tasks belong to the same company and also makes it easy to identify which company it is (for example based on the own company data). The Tasks should be assigned with priority and not with the origin-ID directly
Contributor
|
I removed this pull request from the 6.3.0 milestone |
# Conflicts: # DEPENDENCIES # bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/config/GoldenRecordTaskConfiguration.kt
…-priority-based-record-processing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements priority handling (High, Low) based on thresholds within the orchestrator. It also adds new endpoints for registering gate components with priorities. The orchestrator will generate the
OriginIdautomatically and that will be used by the gate component.Issue: eclipse-tractusx/sig-release#856
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: