refactor(Pool): add refactored logic for creating additional addresses #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces heavy refactoring of the logic for creating additional addresses in the Pool. The newly introduced programming paradigms should lay a foundation for how we want to write code for BPDM applications in the future.
This pull request is part of the developer guide, not only writing down how developers should ideally contribute to BPDM but also showing refactored code how we want BPDM to look like in the future.
This pull request is meant to be a basis for discussion for developer guideline topics. #1344
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: