Open
Conversation
- Introduced new models for BACnet scanning responses in `models.py`, including IP addresses, device properties, and scan results. - Implemented a comprehensive network discovery module in `network_discover_ping.py` to identify reachable networks and responsive IPs using various methods (routing table, ARP table, etc.). - Updated test endpoints to reflect the new module structure and import paths.
There was a problem hiding this comment.
Pull Request Overview
This pull request renames the package from bacnet_scan_tool to bacnet_scan_api and updates dependencies from local directory references to PyPI packages. The changes include a complete rewrite of the test suite with expanded coverage.
- Package renamed from
bacnet-scan-tooltobacnet-scan-apiacross all files - Dependencies updated to use PyPI versions (protocol-proxy >=2.0.0rc2, protocol-proxy-bacnet >=2.0.0rc2)
- Comprehensive test suite added with fixtures and test classes for all major endpoints
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/backend/test_endpoints.py | Complete rewrite with comprehensive test coverage for all API endpoints, but contains incorrect module references to old package name |
| src/bacnet_scan_api/network_discover_ping.py | New network discovery module with multi-platform support for Windows, WSL, and Linux |
| src/bacnet_scan_api/models.py | New Pydantic models defining API request/response schemas |
| src/bacnet_scan_api/init.py | New package initialization file |
| src/bacnet_scan_api/main.py | Updated cache directory path and improved error handling in start_proxy endpoint |
| pyproject.toml | Package renamed, dependencies updated to PyPI versions, dev dependencies added, but contains potentially invalid version specifications |
| README.md | Updated documentation to reflect new package name and repository URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/bacnet_scan_api/main.py:79
- [nitpick] The hardcoded timeout value of 5 seconds could be made configurable through an environment variable or configuration parameter to allow adjustment based on different network conditions without code changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated to use scan_api rather than scan_tool. fixed toml to use pypi packages instead of local dirs.