Core updates by schandrika · Pull Request #318 · eclipse-volttron/volttron-core

schandrika · 2026-04-01T18:44:06Z

No description provided.

Copilot

Pull request overview

This PR updates core platform utilities and management workflows by improving version detection, adding a library removal path (server RPC + CLI), and making wheel filename parsing more robust.

Changes:

Update dev-mode version lookup to read pyproject.toml from repo root and parse TOML via tomli.
Add remove_library support via ControlService RPC, AIP implementation, and a new vctl remove-lib command.
Improve wheel filename parsing to handle both py3 and py2.py3 compatible wheels, with explicit erroring on unexpected formats.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/volttron/utils/version.py`	Adjusts repo-root detection and switches TOML parsing implementation for dev-mode version lookup.
`src/volttron/services/control/control_service.py`	Exposes a new RPC endpoint to remove an installed library via the server AIP.
`src/volttron/server/aip.py`	Implements `poetry remove` for libraries and updates wheel filename parsing logic.
`src/volttron/client/commands/control.py`	Adds a new `remove-lib` CLI subcommand that calls the server RPC.
`pyproject.toml`	Removes the `toml` dependency (but needs alignment with the new TOML parser choice).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/volttron/utils/version.py

Copilot · 2026-04-01T18:48:42Z

src/volttron/utils/version.py

+        root = Path(__file__).parent.parent.parent.parent
        tomle_file = root.joinpath("pyproject.toml")
        if not tomle_file.exists():


Variable name tomle_file looks like a typo (likely meant toml_file). Renaming would improve readability and avoid propagating the misspelling through the error message and subsequent uses.

Copilot · 2026-04-01T18:48:42Z

pyproject.toml

 [tool.poetry.dependencies]
 poetry = "^2.0"
 python = "^3.10"
 gevent = ">=24.2.1,<24.3"
 PyYAML = "^6.0"
-toml = "^0.10.2"
 dateutils = "^0.6.12"
 tzlocal = "^4.1"
 psutil = "^5.9.0"


This PR removes the toml dependency, but the code now reads pyproject.toml via tomli (see src/volttron/utils/version.py). Add tomli (ideally with a Python version marker like <3.11) or switch the implementation to stdlib tomllib so get_version() works in developer mode.

Copilot · 2026-04-01T18:48:42Z

src/volttron/services/control/control_service.py

                                         pre_release=allow_prerelease)

+    @RPC.export
+    def remove_library(self, name):


remove_library is exported over RPC but doesn't follow the parameter type validation pattern used by other RPC methods in this file (e.g., remove_agent, stop_agent validate inputs and include caller identity in the error). Add a str type check (and consistent error message) to avoid unexpected tracebacks from bad RPC inputs.

Suggested change

def remove_library(self, name):

def remove_library(self, name):

# Validate parameter type and include caller identity in error, to match

# the pattern used by other RPC methods in this service.

get_identity = getattr(cc, "get_current_identity", None)

if callable(get_identity):

caller_identity = get_identity()

else:

caller_identity = getattr(cc, "current_identity", "unknown")

if not isinstance(name, str):

raise ValueError(

f"Invalid library name {name!r} (type {type(name).__name__}) from caller {caller_identity}"

)

src/volttron/client/commands/control.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T21:50:02Z

src/volttron/utils/version.py

    __version__ = importlib_metadata.version('volttron-core')

 except importlib_metadata.PackageNotFoundError:
+    # TODO - use tomlib once we migrate to py 3.11 or above


The TODO references tomlib, but the stdlib module name is tomllib (Python 3.11+). Updating the comment avoids confusion and aligns with the actual migration target.

Suggested change

# TODO - use tomlib once we migrate to py 3.11 or above

# TODO - use tomllib once we migrate to py 3.11 or above

Copilot · 2026-04-01T21:50:03Z

src/volttron/utils/version.py

+        root = Path(__file__).parent.parent.parent.parent
+        toml_file = root.joinpath("pyproject.toml")
+        if not toml_file.exists():
            raise ValueError(
-                f"Couldn't find pyproject.toml file for finding version. ({str(tomle_file)})")
-        import toml
+                f"Couldn't find pyproject.toml file for finding version. ({str(toml_file)})")

-        pyproject = toml.load(tomle_file)
+        # Prefer stdlib tomllib when available (Python 3.11+), fall back to tomli if installed.
+        try:


tomli is only installed for Python <3.11 (per pyproject), but python = ^3.10 allows running this code on 3.11+. In a dev checkout on 3.11+, this branch will raise ModuleNotFoundError when volttron-core metadata isn't present. Consider importing tomllib when available and falling back to tomli (or adjust dependencies accordingly).

Copilot · 2026-04-01T21:50:03Z

src/volttron/server/aip.py

+            # handle both py3 and python2&3 compatible wheels
+            stripped = re.sub(r'-(py2\.py3|py3)-[^-]+-[^-]+\.whl$', '', wheel)
+            if stripped == wheel:
+                raise RuntimeError(
+                    f"Unable to parse package name from wheel filename '{wheel}'. "
+                    f"Expected format: {{name}}-{{version}}-(py3|py2.py3)-{{abi}}-{{platform}}.whl"
+                )


The wheel filename parser only accepts python tags py3 or py2.py3 and will raise for valid wheels like pkg-1.0.0-cp310-cp310-manylinux_2_17_x86_64.whl (and also doesn’t account for the optional PEP 427 build tag). Since install_agent_or_lib_source can receive arbitrary wheels, consider parsing per PEP 427 more generally (e.g., accept any python/abi/platform tags and handle an optional build tag) so compiled/tagged wheels don’t get rejected.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T21:59:32Z

src/volttron/server/aip.py

+            # handle both py3 and python2&3 compatible wheels
+            stripped = re.sub(r'-(py2\.py3|py3)-[^-]+-[^-]+\.whl$', '', wheel)
+            if stripped == wheel:
+                raise RuntimeError(
+                    f"Unable to parse package name from wheel filename '{wheel}'. "
+                    f"Expected format: {{name}}-{{version}}-(py3|py2.py3)-{{abi}}-{{platform}}.whl"
+                )
+            agent_name_with_version = stripped.replace("_", "-")


_construct_package_name_from_wheel now only accepts wheel filenames with a py3 or py2.py3 Python tag and raises for other valid wheel tags (e.g., py310, cp310, etc.). Since install_agent_or_lib_source calls this for any .whl, this can break installing perfectly valid wheels. Consider using a standards-based wheel filename parser (or expanding the parsing to cover PEP 427 wheel tags and optional build tags) rather than hard-coding py3|py2.py3 and erroring out.

src/volttron/services/control/control_service.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

schandrika added 3 commits March 31, 2026 15:42

fix to handle py3 and py2+py3 packages

eb5905b

added vctl remove-lib

7bdf178

using tomli instead of toml for pyproject.toml parsing

03faf2b

schandrika requested a review from Copilot April 1, 2026 18:44

Copilot started reviewing on behalf of schandrika April 1, 2026 18:44 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

changes based on copilot review

02a857a

schandrika requested a review from Copilot April 1, 2026 21:45

Copilot started reviewing on behalf of schandrika April 1, 2026 21:46 View session

schandrika and others added 2 commits April 1, 2026 14:46

Update src/volttron/client/commands/control.py

8d08caf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/volttron/utils/version.py

88a6078

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Apr 1, 2026

View reviewed changes

minor var name fix

065cdd2

schandrika requested a review from Copilot April 1, 2026 21:56

Copilot started reviewing on behalf of schandrika April 1, 2026 21:56 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

schandrika and others added 2 commits April 1, 2026 15:02

Update src/volttron/services/control/control_service.py

5fbd268

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

added minor stdout

ddb34ba

schandrika merged commit b789b8a into eclipse-volttron:develop Apr 1, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core updates#318

Core updates#318
schandrika merged 9 commits intoeclipse-volttron:developfrom
schandrika:core_updates

schandrika commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    def remove_library(self, name):
+    def remove_library(self, name):
+        # Validate parameter type and include caller identity in error, to match
+        # the pattern used by other RPC methods in this service.
+        get_identity = getattr(cc, "get_current_identity", None)
+        if callable(get_identity):
+            caller_identity = get_identity()
+        else:
+            caller_identity = getattr(cc, "current_identity", "unknown")
+        if not isinstance(name, str):
+            raise ValueError(
+                f"Invalid library name {name!r} (type {type(name).__name__}) from caller {caller_identity}"
+            )

	# TODO - use tomlib once we migrate to py 3.11 or above
	# TODO - use tomllib once we migrate to py 3.11 or above

Conversation

schandrika commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants