Skip to content

Added EnergyPlus simulation agent into modular VOLTTRON#1

Open
riley206-pnnl wants to merge 28 commits intoeclipse-volttron:developfrom
riley206-pnnl:main
Open

Added EnergyPlus simulation agent into modular VOLTTRON#1
riley206-pnnl wants to merge 28 commits intoeclipse-volttron:developfrom
riley206-pnnl:main

Conversation

@riley206-pnnl
Copy link
Copy Markdown

Description

Added EnergyPlus simulation agent into modular VOLTTRON.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested on fresh Ubuntu 22.04.2 virtual machine

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@craig8
Copy link
Copy Markdown

craig8 commented Aug 22, 2023

This is the wrong license. Please look at https://github.com/eclipse-volttron/volttron-core for guidance on how to properly add LICENSE and code copyright.

@craig8 craig8 changed the base branch from main to develop August 22, 2023 20:38
@craig8
Copy link
Copy Markdown

craig8 commented Aug 22, 2023

Ideally we should have many more commits than just the 2. We should be able to trace the code from when you started from the VOLTTRON/volttron repository and changed it to the modular. There should be a single commit for the setup of this repository with poetry etc the rest should be small incremental changes.

@craig8
Copy link
Copy Markdown

craig8 commented Aug 22, 2023

You should not have wheel files committed to the repository. There should be a .gitignore in the root (see volttron-core)

@riley206-pnnl
Copy link
Copy Markdown
Author

Ideally we should have many more commits than just the 2. We should be able to trace the code from when you started from the VOLTTRON/volttron repository and changed it to the modular. There should be a single commit for the setup of this repository with poetry etc the rest should be small incremental changes.

Yes that makes sense. The reason for that not existing is because I did not even clone the repo I just copied files and started work on it. Once you pointed me to the empty cloned repo that was to be used. I uploaded everything at once. This will not happen in the future.

@riley206-pnnl riley206-pnnl reopened this Aug 22, 2023
@craig8
Copy link
Copy Markdown

craig8 commented Oct 5, 2023

Please use a .gitignore from one of the other repositories as this one is not complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants