Generator fragment for textmate grammars and Xbase LSP server infra#2969
Merged
Generator fragment for textmate grammars and Xbase LSP server infra#2969
Conversation
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
szarnekow
force-pushed
the
sz_issue1329
branch
3 times, most recently
from
0e568f5 to
dc737fb
Compare
szarnekow
commented
Apr 13, 2024
org.eclipse.xtend.core/xtend-gen/org/eclipse/xtend/core/macro/TransformationContextImpl.java
Show resolved
Hide resolved
szarnekow
changed the title
Also: - Optionally write project configuration from StandaloneBuilder It includes a content hash for change tracking of jars - Fixed typos in local variable names - Remove duplicated tests and obsolete test-data - Expose mechanism to clear the cache for classpath-based jvm types - Optionally allow to obtain the location URI from a class mirror Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
LorenzoBettini
approved these changes
Apr 14, 2024
Contributor
LorenzoBettini
left a comment
LorenzoBettini
left a comment
There was a problem hiding this comment.
@szarnekow I only left a few minor comments.
|
|
||
| private StandaloneBuilder initBuilder(ILanguageConfiguration config, String... srcDirs) { | ||
| List<String> patthes = new ArrayList<String>(); | ||
| List<String> pathes = new ArrayList<String>(); |
Contributor
There was a problem hiding this comment.
nip: shouldn't it be paths?
Also later
| @@ -1,5 +1,5 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2020 itemis AG (http://www.itemis.eu) and others. | |||
| * Copyright (c) 2020, 2023 itemis AG (http://www.itemis.eu) and others. | |||
Contributor
There was a problem hiding this comment.
shouldn't it be 2024?
| incremental = enable; | ||
| } | ||
|
|
||
| public void setClasspathConfigurationLocation(String location, String key, String outputDirectory) { |
Contributor
There was a problem hiding this comment.
Do we use since annotations here at all?
| src-gen/,\ | ||
| src-no-jdt/,\ | ||
| src-standalone/ | ||
| src-no-jdt/ |
Contributor
There was a problem hiding this comment.
The final "/" shouldn't be needed, should it?
| } | ||
|
|
||
| @Deprecated | ||
| protected BinaryClassMirror(BinaryClass binaryClass, ITypeFactory<BinaryClass, JvmDeclaredType> typeFactory) { |
Contributor
There was a problem hiding this comment.
Maybe a comment about deprecation
| public class HoverIdeStrings extends UIStrings { | ||
|
|
||
| @Override | ||
| public String typeParameters(Iterable<? extends JvmTypeParameter> typeParams) { |
Contributor
There was a problem hiding this comment.
Don't we already have something similar in our code base?
| } | ||
| }; | ||
| StringBuilder result = new StringBuilder(250); | ||
| if (typeArgumentCount != constructorTypeArgumentCount) { |
Contributor
There was a problem hiding this comment.
As above, don't we already have something similar?
The two loops also seem to contain some duplicated code.
| typeProvider.clearCache(); | ||
| } | ||
| JvmTypeChangeDispatcher dispatcher = JvmTypeChangeDispatcher.findResourceChangeDispatcher(resourceSet); | ||
| EObject dummy = EcoreFactory.eINSTANCE.createEObject(); |
Contributor
There was a problem hiding this comment.
What is the meaning of this dummy used with eNotify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.