Depend on JUnit 6 instead of JUnit 5#3560
Draft
trancexpress wants to merge 3 commits intoeclipse-xtext:mainfrom
Draft
Depend on JUnit 6 instead of JUnit 5#3560trancexpress wants to merge 3 commits intoeclipse-xtext:mainfrom
trancexpress wants to merge 3 commits intoeclipse-xtext:mainfrom
Conversation
Contributor
Author
|
There is a surprising number of JUnit 5 mentions, including even a quick fix action for adding JUnit 5 to the classpath... Probably for This PR so far doesn't touch any of those. |
trancexpress
force-pushed
the
gh3552
branch
2 times, most recently
from
2c93f7a to
ad11eb8
Compare
Contributor
Author
|
Running Fully summary: At least in JDT/PDE, this was usually an indicator of mixing JUnit 5 and 6 at runtime. It might be something else here. Such as JUnit 4 tests... Trying this: Results in: |
Contributor
|
maybe this is a way too old tycho? |
cdietrich
reviewed
Nov 19, 2025
Contributor
Author
Should I try updating to |
Contributor
|
see #3509 we had a brief discussion to look into that someone after the current release (building milestones and releases is actually already beyond my cappa) |
Contributor
|
the problem with tycho 5 is
what happens if use selects java 17 in wizard? should we have a fallback to old version. this also affecs junit 5/6 what should we offer the user. |
Contributor
|
can you also check Jenkinsfile |
Contributor
Author
|
With |
Contributor
Author
We can always delay the JUnit 6 update for when Advantest is not in a rush, since the workaround is trivial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #3552