[ECM-43] Basic Kafka implementation in combination: order-service<->payment-service#7
Merged
ariemic merged 7 commits intodevelopmentfrom Oct 9, 2025
Merged
[ECM-43] Basic Kafka implementation in combination: order-service<->payment-service#7ariemic merged 7 commits intodevelopmentfrom
ariemic merged 7 commits intodevelopmentfrom
Conversation
ariemic
requested changes
Oct 5, 2025
src/main/java/com/ecmsp/paymentservice/payment/adapter/repository/db/PaymentEntity.java
Show resolved
Hide resolved
src/main/java/com/ecmsp/paymentservice/payment/adapter/repository/db/PaymentEventEntity.java
Show resolved
Hide resolved
src/main/java/com/ecmsp/paymentservice/payment/domain/PaymentStatus.java
Show resolved
Hide resolved
src/main/java/com/ecmsp/paymentservice/api/kafka/PaymentRequestedKafkaConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ecmsp/paymentservice/api/kafka/PaymentRequestedKafkaConsumer.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
as written above create domain record
Member
Author
There was a problem hiding this comment.
We already have PaymentRequestedKafkaEvent in api/kafka 😅
Contributor
There was a problem hiding this comment.
also create domain record for kafka only
Member
Author
There was a problem hiding this comment.
Actually, we already have records PaymentProcessedKafkaEventSucceeded and PaymentProcessedKafkaEventFailed, but they are not extended with the fields offered by PaymentResponse. We can extend these two domain records with these fields, but do we want to?
ariemic
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.