-
Notifications
You must be signed in to change notification settings - Fork 6
Add genesis information to configure.sh script as per issue #32 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38 +/- ##
===========================================
+ Coverage 40.67% 40.68% +0.01%
===========================================
Files 49 49
Lines 10131 10133 +2
===========================================
+ Hits 4121 4123 +2
Misses 6010 6010 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for this addition. To be honnest, I was expecting a ".genesis" file generated on disk, but I believe you have good arguments to insert this as a comment in My question is when is this GENESIS comment created and updated ? Is it the first time you start the build command ? |
|
Indeed this effectively inserts the GENESIS content as a comment, but without the The --dryrun option to ecbundle-build already creates the configure.sh script with all extra options requested. It just prevents to launch the "configure.sh" and "build.sh" script. Every time you execute again the "ecbundle-build" command for the same |
|
Thanks for the explanations, Willem. I think I'am happy with the feature, at least when it will be properly documented to explain the backup system and where to find the |
|
@wdeconinck Do you plan to merge this soon ? |
* release/2.4.0: Version 2.4.0 Manage multi-remotes (#40) Fix QA code due to updated black Add genesis information to configure.sh script as per issue #32 (#38) Fix printing of version in the generated configure/build/install scripts (#37) Only raise symlink failure error if target exists (#35) Revert to absolute symlinks if relative link generation fails (#30)
This change adds the command line instruction that generated the
configure.shscript in the build directory.An example
configure.shheader will now look like: