Skip to content

Conversation

@pgeier
Copy link
Contributor

@pgeier pgeier commented Feb 2, 2026

Description

This PR removes the usage of metkit/GribHandle everywhere possible in favor of new CodesHandle.
Fully removal will change once subsequent PRs using old CodesHandle have been merged.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch 2 times, most recently from 9b56514 to e8e01cc Compare February 2, 2026 14:14
@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch from e8e01cc to c25e744 Compare February 2, 2026 14:21
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 38.51351% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.01%. Comparing base (15a0584) to head (c25e744).

Files with missing lines Patch % Lines
src/metkit/codes/CodesDataContent.cc 25.00% 42 Missing ⚠️
src/metkit/pointdb/PointIndex.cc 0.00% 16 Missing ⚠️
src/metkit/pointdb/GribFieldInfo.cc 0.00% 12 Missing ⚠️
src/metkit/codes/api/CodesAPI.cc 76.66% 7 Missing ⚠️
src/metkit/codes/GribHandle.cc 0.00% 6 Missing ⚠️
src/metkit/pointdb/GribHandleDataSource.cc 0.00% 5 Missing ⚠️
src/metkit/codes/BufrContent.cc 33.33% 2 Missing ⚠️
src/metkit/codes/BUFRDecoder.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
- Coverage    54.31%   54.01%   -0.31%     
===========================================
  Files          298      297       -1     
  Lines        11514    11490      -24     
  Branches      1021     1022       +1     
===========================================
- Hits          6254     6206      -48     
- Misses        5260     5284      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants