Open
Conversation
added 2 commits
March 4, 2015 14:51
src/CatchersPool.js
Outdated
Member
There was a problem hiding this comment.
- 这么做的原因是什么，在
events上加个事件有别人用吗？ events注入吗？
Author
There was a problem hiding this comment.
- 当时这么做的考虑是events有一个好处就是允许多次绑定，所以就把onReject又封装成事件了。
- 那些require的东西都会考虑注入，过后加上。
Author
There was a problem hiding this comment.
第一个问题，等着欣欣的升级版本；第二个问题，跟着其余的，现在都改成注入模式了。
修改除了异常处理以外的其它codereview问题
src/CatchersPool.js
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
er-track改版