Streams

[halmhatt]

Add stream support to morse lib.

It is possible to use streams programmatically and using pipes in the cli.

[ecto]

This is dope! Could you change all indents to 2 spaces? I'll push it then :)

Thanks man! Great code

[halmhatt]

Hi, thanks! I have changed all tabs to spaces now both test/streamSpec.js and README.md.

Thanks, this will be my first merged pull request!

Great work with the library!

[ecto]

Still some tabs in test/array.js

[halmhatt]

Oh sorry, my intention was not to change that file, sorry. I was just
playing with mocha

2015-01-31 20:13 GMT+01:00 Cam Pedersen notifications@github.com:

In test/array.js
#3 (comment):

-var decoded = morse.decode(encoded);

-console.log(decoded);

-var expected = [

• 'HELLO',
• 'WORLD'
  -];

-console.log(expected[1] == decoded[1] ? 'pass' : 'fail');

•   assert.deepEqual(decoded, arr.map(function(str) {
  

•       return str.toUpperCase();
  

•   }), 'Arrays should be equal except for case');
  

• });

Still some tabs in test/array.js

—
Reply to this email directly or view it on GitHub
https://github.com/ecto/morse/pull/3/files#r23891251.

[joernroeder]

Hey, any updates on this?

[halmhatt]

I think its done, even the formatting. But i will take a look later

[halmhatt]

I have updated the dependencies. Everything seems to be working normally. Is there anything else I need to fix?

I ran test/dichotomic.js but it fails. Even if I checkout master and install npm dependencies again. But if it is not just for me this could just be a bug.

[etroynov]

@ecto