JIRA-ONSBUSWI-3596: [SONiC][as9817-64] Fix fan tolerance logic skipped when BMC thermal control is active#691
Merged
bryan1978 merged 1 commit intoedge-core:202311.Xfrom Mar 25, 2026
Conversation
…d when BMC thermal control is active 31a468, the fan speed tolerance adjustment logic in manage_fans was placed after the BMC thermal control check. If the BMC was actively managing the thermal policy, the function would return early, causing the tolerance settings (on/off) and timers to be skipped. This commit refactors the fan tolerance logic into a separate method adjust_tolerance() and ensures it is called in both the BMC-controlled and CPU-controlled paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
31a468, the fan speed tolerance adjustment logic in manage_fans was placed after the BMC thermal control check. If the BMC was actively managing the thermal policy, the function would return early, causing the tolerance settings (on/off) and timers to be skipped.
This commit refactors the fan tolerance logic into a separate method adjust_tolerance() and ensures it is called in both the BMC-controlled and CPU-controlled paths.