Skip to content

[device] Accton AS5712-54x: fix Python script errors preventing platform monitor startup#692

Open
LorenzYouKnow wants to merge 1 commit intoedge-core:202311.Xfrom
LorenzYouKnow:device/as5712-54x/platform-monitor-service-unable-to-start
Open

[device] Accton AS5712-54x: fix Python script errors preventing platform monitor startup#692
LorenzYouKnow wants to merge 1 commit intoedge-core:202311.Xfrom
LorenzYouKnow:device/as5712-54x/platform-monitor-service-unable-to-start

Conversation

@LorenzYouKnow
Copy link

Why I did it

The as5712-platform-monitor.service was failing to start in my lab
This change fixes python script issues so the platform monitoring service can start

How I did it

Update the platform monitoring python sources:

  • fixed inconsistent tab/space indentation in:
    • platform/broadcom/sonic-platform-modules-accton/as5712-54x/classes/fanutil.py
    • platform/broadcom/sonic-platform-modules-accton/as5712-54x/classes/thermalutil.py
  • added missing "import sys" in:
    • platform/broadcom/sonic-platform-modules-accton/as5712-54x/utils/accton_as5712_monitor.py

How to verify it

  1. Build and install a image with this change on my AS5712-54X
  2. Start/Checked the platform monitor service after boot

…itor.service not starting

accton_as5712_monitor.py: Import sys for line 198
thermalutil.py: Fixed inconsistent use of tabs and spaces in indentation
fanutil.py: Fixed inconsistent use of tabs and spaces in indentation

Signed-off-by: Lorenz K. <github@SoichiroYagami.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant