refactor(common): reorganize UDFs into modules and add docs #1545
+1,014
−721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shiyasmohd
commented
Jan 13, 2026
shiyasmohd
commented
- Reorganize UDF module. No functional changes.
- add docs for each UDF
LNSD
requested changes
Jan 13, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
Please, check my comments 🙂
Also, review the visibility (pub modifiers) of the different functions. Only those that are actually used outside of these modules should be made public. It is a best practice to default always to private visibility.
Contributor
Author
|
@LNSD Pushed the changes. |
LNSD
requested changes
Jan 13, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
Please, check my comments 🙂
shiyasmohd
force-pushed
the
shiyasmohd/split-udfs
branch
from
7cb7837 to
ab180fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.