Open
Conversation
yoursunny
reviewed
Feb 10, 2025
Contributor
yoursunny
left a comment
yoursunny
left a comment
There was a problem hiding this comment.
It's unnecessary to maintain separate Dockerfiles for amd64 and arm64.
Instead, use dpkg-architecture command (and possibly some if-else conditions) so that you can have a single Dockerfile for all architectures.
| # Install dependencies for ebpf compilation | ||
| RUN apt update \ | ||
| && apt install --no-install-recommends -y clang llvm gcc libbpf-dev \ | ||
| && rm -rf /var/lib/apt/lists/* |
Contributor
There was a problem hiding this comment.
You deleted the apt cache here, and then populated the apt cache again on line10.
|
|
||
| RUN apt-get update && apt-get install -y linux-headers-arm64 | ||
|
|
||
| RUN ln -s /usr/include/aarch64-linux-gnu/asm/ /usr/include/asm \ |
Contributor
There was a problem hiding this comment.
aarch64-linux-gnu => $(dpkg-architecture -qDEB_TARGET_MULTIARCH)
| && apt install --no-install-recommends -y clang llvm gcc libbpf-dev \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN apt-get update && apt-get install -y linux-headers-arm64 |
Contributor
There was a problem hiding this comment.
arm64 => $(dpkg-architecture -qDEB_TARGET_ARCH_CPU)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.