fix issue not convert to space in data items fix #41#40
Open
AbrahemAlhofe wants to merge 1 commit intoeditor-js:masterfrom
Open
fix issue not convert to space in data items fix #41#40AbrahemAlhofe wants to merge 1 commit intoeditor-js:masterfrom
AbrahemAlhofe wants to merge 1 commit intoeditor-js:masterfrom
Conversation
neSpecc
requested changes
Jul 22, 2020
Contributor
neSpecc
left a comment
neSpecc
left a comment
There was a problem hiding this comment.
Please, attach an issue describing a problem you resolve
Author
|
i have been added yet |
Contributor
|
There is still no attached issue |
Author
|
Do you mean in commit message i did not put "close #issue number" ya.? |
Contributor
yes, you can add it to the PR's description |
AbrahemAlhofe
changed the title
Author
|
That is okay |
|
@AbrahemAlhofe can u provide some description about the PR? What kind of issue are you trying to solve with this PR? |
|
This issue still persist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get data was get inner html of list items and replace
elements to space but there is other browsers like chrome convert spaces in the end of text to
so it was important to replace to space