Fix: Unable to Delete List items (ordered and unordered)#96
Open
donnfelker wants to merge 1 commit intoeditor-js:masterfrom
Open
Fix: Unable to Delete List items (ordered and unordered)#96donnfelker wants to merge 1 commit intoeditor-js:masterfrom
donnfelker wants to merge 1 commit intoeditor-js:masterfrom
Conversation
The backspace update from editor-js#95 worked, but the event listeners are lost when the toggleTune is invoked. This PR adds the listeners back after the tune is invoked. The listeners are lost because replaceWith does not propogate the existing listeners to the new element.
Author
|
Other devs: See #90 for a code snippet you can use to fix it locally until this is merged. |
|
Just tested it and it seems to work! Could one of the contributors take a look at this? |
|
I tested it too. It seems to work. I think this is a very important fix for this plugin. Could one of the contributors take a look at this? Thanks a lot. |
|
@neSpecc How does it work with the versioning? Does every pull request need a version in package.json? If yes then here it is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the fix from #95 as well as an additional fix to re-attach the listeners after the
element.replaceWithwas invoked.The backspace update from #95 worked, but the event listeners are lost when the toggleTune is invoked. This
PR adds the listeners back after the tune is invoked.
The listeners are lost because replaceWith does not propagate the existing listeners to the new element.
Also related to #90