Conversation
Author
|
I've added all the cli args I wanted to add and rebased to the latest commit. |
Author
|
Any updates on this? Anything I might need to change? |
96c64ac to
1ac735e
Compare
0bc55af to
0013228
Compare
It was implemented into master already
|
Merged master into this branch on a local copy - minor conflicts but after resolving them it works perfectly. Would love to have this in a future release, I currently need a way to start EDOPro in replay mode from the command-line. This will suffice in the meantime and I can update my copy as needed but having it in the official releases would be awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following commands to the CLI. I also made it so the replay starts paused, it felt like it made more sense. When a new game is created there will be a log line with the game ID logged.
Config definitions:
I would have loved to use some std::variant but I've seen the project is currently on C++14, so I just kept it simple.