drafted code for a poc for genesis mode#293
Open
realZenith wants to merge 3 commits intoedo9300:masterfrom
Open
drafted code for a poc for genesis mode#293realZenith wants to merge 3 commits intoedo9300:masterfrom
realZenith wants to merge 3 commits intoedo9300:masterfrom
Conversation
including ->checking the deck if the goes above the standard 100 PTS and locking it to add further Point cards if you have the "Genesys" check enabled ->Adding around 105 Strings starting from 12126->12230 ->Adding DUEL_MODE_GENESIS, so you can autostart into the Genesys Mode ->Added a visible notice for the total amount of Genesys PTS in your Deck, right besides the Deck Count if you have the Genesys Setting enabled ->added a duel check if you have genesys setting enabled that checks if you have to many points in deck (doesnt work properly yet) ->added LIMITATION_FILTER from 0 - 100 (only those currently in the current banlist are coded) Currently Missing -> Custom Point Cap for Genesys Rooms -> idk
|
why 100 entries |
Author
Its not 100 Entries, its around 25~, i just choose this approach since its a unfamiliar codebase, and i had some problems setting it up. That's why I just took a simpler approach without rewriting codebase Yes i could write it better, but i just choose this approach for simplicity lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
included are the following
->checking the deck if the goes above the standard 100 PTS and locking it to add further Point cards if you have the "Genesys" check enabled
->Adding around 105 Strings starting from 12126->12230
->Adding DUEL_MODE_GENESIS, so you can autostart into the Genesys Mode
->Added a visible notice for the total amount of Genesys PTS in your Deck, right besides the Deck Count if you have the Genesys Setting enabled
->added a duel check if you have genesys setting enabled that checks if you have to many points in deck (doesnt work properly yet)
->added LIMITATION_FILTER from 0 - 100 (only those currently in the current banlist are coded)
Currently Missing
-> Custom Point Cap for Genesys Rooms
-> idk
-> Serverside validation of a the pointlist?
-> updated strings.conf and a Genesys.lflist.conf arent included here either
I just want your Opinion for now what needs to be changed and what i have coded incorrect