Feature/772 nostalrius fixes#1092
Closed
jeansouzak wants to merge 6 commits intoedubart:masterfrom
jeansouzak:feature/772-nostalrius-fixes
Closed
Feature/772 nostalrius fixes#1092jeansouzak wants to merge 6 commits intoedubart:masterfrom jeansouzak:feature/772-nostalrius-fixes
jeansouzak wants to merge 6 commits intoedubart:masterfrom
jeansouzak:feature/772-nostalrius-fixes
Conversation
slavidodo
reviewed
Jun 25, 2020
| if(g_map.isAwareOfPosition(goalPos)) { | ||
| const TilePtr goalTile = getTile(goalPos); | ||
| if(!goalTile || !goalTile->isWalkable((flags & Otc::PathFindAllowCreatures))) { | ||
| if(!goalTile || !goalTile->isWalkable()) { |
Collaborator
There was a problem hiding this comment.
We did a PR earlier to solve that specifically.
Why are you removing it now?
| wasSeen = true; | ||
| if(const TilePtr& tile = getTile(neighborPos)) { | ||
| hasCreature = tile->hasCreature(); | ||
| isNotWalkable = !tile->isWalkable((flags & Otc::PathFindAllowCreatures)); |
|
|
||
| function onFreeCapacityChange(player, freeCapacity) | ||
| capLabel:setText(tr('Cap') .. ': ' .. freeCapacity) | ||
| capLabel:setText(tr('Cap') .. ': ' .. (freeCapacity * 100)) |
| addCreature(creature) | ||
| end | ||
|
|
||
| addCreature(creature) |
|
|
||
| -- Hack fix to resolve some 760 login issues | ||
| if g_game.getClientVersion() <= 760 then | ||
| if g_game.getClientVersion() <= 792 then |
Collaborator
There was a problem hiding this comment.
im not aware of this, so it might be :)
Contributor
|
Are those removals in modules/game_hotkeys/hotkeys_manager.otui relvant regardless of protocol? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fixes for 772 version and nostalrius (https://github.com/TwistedScorpio/Nostalrius) server.
I requested one PR with server modification as well (Ezzz-dev/Nostalrius#59)