feat: add issuer_state to credential request body too #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support any OIDC server, we need to add the issuer state to the body. The OIDC4VCI spec doesn't define a standard way to relay the issuer state, many implementations presume it is part of the access token. But the spec also requires the access token to be considered "opaque". And most OIDC servers won't pass the issuer_state in their access token along - if they have a JWT in the first place! The spec allow additional attributes so adding it, should not cause trouble at issuers - they should simply ignore it if they cannot handdle it. Hence, we duplicate the issuer_state in the body - e.g. the Sphereon agent handles this extra attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support any OIDC server, we need to add the issuer state to the body. The OIDC4VCI spec doesn't define a standard way to relay the issuer state, many implementations presume it is part of the access token. But the spec also requires the access token to be considered "opaque". And most OIDC servers won't pass the issuer_state in their access token along - if they have a JWT in the first place! The spec allow additional attributes so adding it, should not cause trouble at issuers - they should simply ignore it if they cannot handdle it.
Hence, we duplicate the issuer_state in the body - e.g. the Sphereon agent handles this extra attribute.