Open
Conversation
Add a case to ClientSocket.c to make sure it compiles. Add prototype for cuserid - newer Clang in FreeBSD rejects use without a prototype. Update compilation scripts. Modern compilers require -fcommon to build this code. There are a few places left where the platform is not correctly detected, but it appears that default assumptions work for now.
Contributor
Author
|
This compiles and runs seemingly OK on new projects, but has some issues opening demo files on FreeBSD. Should not affect other platforms. |
Owner
What's the issue there do you know? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a case to ClientSocket.c to make sure it compiles. Add prototype for cuserid - newer Clang in FreeBSD rejects use without a prototype.
Update compilation scripts. Modern compilers require -fcommon to build this code.
There are a few places left where the platform is not correctly detected, but it appears that default assumptions work for now.