Add full response for directions api#10
Open
jguthrie100 wants to merge 2 commits intoedwardsamuel:masterfrom
Open
Add full response for directions api#10jguthrie100 wants to merge 2 commits intoedwardsamuel:masterfrom
jguthrie100 wants to merge 2 commits intoedwardsamuel:masterfrom
Conversation
- When doing a directions search, if you enter an invalid address (i.e. 'dsadsfdfdscfrcerf, Tanzania'), a NotFoundError is raised
…amuel#6) Added a feature that allows 'return_type: :all' to be passed into the client.directions method, which returns the full Hash output, rather than just the [:routes] entry Can change the argument to be 'return_type: :status' if you just want the status, or leave it blank to get the [:routes] value (i.e. the same output as is the case without this change)
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a feature that allows 'return_type: :all' to be passed into the client.directions method, which returns the full Hash output, rather than just the [:routes] entry
Can change the argument to be 'return_type: :status' if you just want the status, or leave it blank to get the [:routes] value (i.e. the same output as is the case without this change)