[ fix ] handling of VCase in Core.Case.Builder.sameType#35
Open
AlgebraicWolf wants to merge 1 commit intoedwinb:mainfrom
Open
[ fix ] handling of VCase in Core.Case.Builder.sameType#35AlgebraicWolf wants to merge 1 commit intoedwinb:mainfrom
VCase in Core.Case.Builder.sameType#35AlgebraicWolf wants to merge 1 commit intoedwinb:mainfrom
Conversation
Current implementation of `headEq` inside `Core.Case.Builder.sameType`
considers two `VCase`s to always be different. Because of this, the
following example fails to compile.
```idris
module Main
public export
record X (flag : Bool) where
constructor MkX
x : if flag then Bool else Void
f : X True -> ()
f (MkX True) = ()
f (MkX False) = ()
```
Instead, the following compilation error is produced:
```
Error: Patterns for f require matching on different types.
Main:13:1--13:18
09 | constructor MkX
10 | x : if flag then Bool else Void
11 |
12 | f : X True -> ()
13 | f (MkX True) = ()
^^^^^^^^^^^^^^^^^
```
This patch changes the behaviour of `headEq` to make it treat `VCase`s
as equal, eliminating the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
headEqinsideCore.Case.Builder.sameTypeconsiders twoVCases to always be different. Because of this, the following example fails to compile.Instead, the following compilation error is produced:
This patch changes the behaviour of
headEqto make it treatVCases as equal, eliminating the error.