Skip to content

Conversation

@muhammad-ammar
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 22, 2025 10:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR pins the pylint version to 3.3.8 to address a compatibility or stability issue tracked in ENT-11087. The change adds a version constraint to prevent automatic upgrades to potentially problematic newer versions of pylint.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

# This can be unpinned once https://github.com/openedx/edx-lint/issues/459 has been resolved.
pip<24.3

# https://2u-internal.atlassian.net/browse/ENT-11087
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should explain why pylint is being pinned (e.g., what issue it addresses) and under what conditions it can be unpinned, similar to the pip constraint above. Consider adding details about the specific problem with newer versions and the resolution criteria.

Suggested change
# https://2u-internal.atlassian.net/browse/ENT-11087
# https://2u-internal.atlassian.net/browse/ENT-11087
# Pinning pylint to 3.3.8 due to issues with newer versions causing false positives and breaking CI linting checks.
# This can be unpinned once the issues described in ENT-11087 are resolved, and pylint >=3.4 is verified to work with our codebase.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

…ts-bdbc24c

chore: Upgrade Python requirements
@muhammad-ammar muhammad-ammar merged commit e879505 into master Oct 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants