Skip to content

Conversation

@Faraz32123
Copy link

@Faraz32123 Faraz32123 commented Sep 5, 2025

Ticket: COSMO2-716

  • dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work.
    • So, replace dialogClassName with simple className to apply same styles to get the past behavior for the modal.

Please review
paragon v22 Modal Props VS paragon ModalDialog Props API which used className instead of dialogClassName.

Link to upstream openedx PR: openedx#1787

- dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work.
  - So, replace dialogClassName with simple className to apply same styles.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@e82132d). Learn more about missing BASE report.
⚠️ Report is 694 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   90.90%           
=========================================
  Files             ?      344           
  Lines             ?     5784           
  Branches          ?     1372           
=========================================
  Hits              ?     5258           
  Misses            ?      507           
  Partials          ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nsprenkle nsprenkle merged commit 724039c into edx:master Sep 5, 2025
4 checks passed
@Faraz32123 Faraz32123 self-assigned this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants