fix: should point to forked repo #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dockerfile, only used by edx, should point to the forked copy of credentials. Otherwise it runs into trouble trying to fetch commit hashes. (this is also otherwise we might run into divergent problems)
There was a problem hiding this comment.
Pull request overview
This PR updates the credentials Dockerfile to point to the edx fork of the credentials repository instead of the upstream openedx repository. This change is necessary for edx to avoid issues when fetching commit hashes and potential divergence problems.
Changes:
- Updated the default value of
CREDENTIALS_SERVICE_REPOARG fromopenedx/credentialstoedx/credentials - Updated hardcoded GitHub raw URLs for fetching requirements files to use
edx/credentialsinstead ofopenedx/credentials
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsnwesson
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dockerfile, only used by edx, should point to the forked copy of credentials. Otherwise it runs into trouble trying to fetch commit hashes. (Also, otherwise we will eventually run into problems with divergence.)