Skip to content

Support millisecond accuracy when reporting time with an event #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kas-code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support millisecond accuracy when reporting time with an event #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Mixpanel/Mixpanel.Tests/MixpanelTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public abstract class MixpanelTestsBase
protected static readonly DateTime Time = new DateTime(2013, 11, 30, 0, 0, 0, DateTimeKind.Utc);
protected static readonly DateTimeOffset TimeOffset = new DateTimeOffset(2013, 11, 30, 0, 0, 0, TimeSpan.Zero);
protected const long TimeUnix = 1385769600L;
protected const string TimeFormat = "2013-11-30T00:00:00";
protected const string TimeFormat = "2013-11-30T00:00:00.000";
protected const double DurationSeconds = 2.34D;
protected static readonly TimeSpan Duration = TimeSpan.FromSeconds(DurationSeconds);
protected const string Os = "Windows";
Expand All @@ -28,7 +28,7 @@ public abstract class MixpanelTestsBase
protected const string LastName = "Vader";
protected const string Name = "Darth Vader";
protected static readonly DateTime Created = new DateTime(2014, 10, 22, 0, 0, 0, DateTimeKind.Utc);
protected const string CreatedFormat = "2014-10-22T00:00:00";
protected const string CreatedFormat = "2014-10-22T00:00:00.000";
protected const string Email = "darth.vader@mail.com";
protected const string Phone = "589741";
protected const string Alias = "999";
Expand Down
4 changes: 2 additions & 2 deletions src/Mixpanel/Mixpanel/Parsers/TimeParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Mixpanel.Parsers
internal static class TimeParser
{
private const long UnixEpoch = 621355968000000000L;
private const string MixpanelDateFormat = "yyyy-MM-ddTHH:mm:ss";
private const string MixpanelDateFormat = "yyyy-MM-ddTHH:mm:ss.fff";

public static ValueParseResult ParseUnix(object rawDateTime)
{
Expand Down Expand Up @@ -65,7 +65,7 @@ public static ValueParseResult ParseMixpanelFormat(object rawDateTime)

default:
return ValueParseResult.CreateFail(
"Expected types are: DateTime, DateTimeOffset or correctly formatted Mixpanel date string (yyyy-MM-ddTHH:mm:ss).");
"Expected types are: DateTime, DateTimeOffset or correctly formatted Mixpanel date string (yyyy-MM-ddTHH:mm:ss.fff).");
}
}
}
Expand Down