Skip to content

Fixed devcontainer and build in git workflow#1

Merged
eelcovv merged 8 commits intoeelcovv:mainfrom
dave-Lab-and-Engineering:main
Oct 3, 2025
Merged

Fixed devcontainer and build in git workflow#1
eelcovv merged 8 commits intoeelcovv:mainfrom
dave-Lab-and-Engineering:main

Conversation

@eelcovv
Copy link
Owner

@eelcovv eelcovv commented Oct 3, 2025

We were running prettier locally, but this does not work in de github actions. therefore moved back to the prettier hook and updated the devcontainer

Summary by Sourcery

Standardize the development container and CI workflows by enhancing the devcontainer setup, migrating the Prettier hook back into pre-commit, updating dependencies, and removing outdated files.

Enhancements:

  • Harden the devcontainer postCreateCommand script with strict bash options, install the uv binary to /usr/local/bin, sync with --dev, and overwrite pre-commit hooks
  • Add tox>=4.30.3 to development dependencies in pyproject.toml

CI:

  • Bump pre-commit-hooks to v6.0.0 and replace the local Prettier hook with the official pre-commit-prettier repo at v3.6.2

Chores:

  • Remove obsolete Dockerfile, package.json, and package-lock.json files

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR tightens up the devcontainer setup with stricter scripting and proper uv installation, restores a standalone Prettier hook for CI (bumping hook versions), adds tox to Python dev dependencies, and cleans up obsolete lock/config files.

Class diagram for updated pre-commit hook configuration

classDiagram
class "pre-commit-config.yaml" {
  +repos: list
}
class "pre-commit/pre-commit-hooks" {
  +rev: v6.0.0
  +hooks: check-case-conflict, check-merge-conflict, check-yaml, end-of-file-fixer, trailing-whitespace, ruff-format
}
class "JoC0de/pre-commit-prettier" {
  +rev: v3.6.2
  +hook: prettier
  +args: ["--write"]
  +types_or: [javascript, jsx, ts, tsx, json, markdown, yaml, css, scss, html]
}
"pre-commit-config.yaml" --> "pre-commit/pre-commit-hooks"
"pre-commit-config.yaml" --> "JoC0de/pre-commit-prettier"
Loading

Class diagram for updated Python dev dependencies

classDiagram
class "pyproject.toml" {
  +dev: [codecov, setuptools, cython, tox]
}
class "tox" {
  +version: ">=4.30.3"
}
"pyproject.toml" --> "tox"
Loading

File-Level Changes

Change Details Files
Refine devcontainer post-create script
  • Add strict bash flags (set -euo pipefail)
  • Ensure uv binary is installed to /usr/local/bin
  • Use uv sync with --dev flag and verify version
  • Run pre-commit install with --overwrite
.devcontainer/postCreateCommand.sh
Update pre-commit config and Prettier integration
  • Bump pre-commit-hooks repo rev to v6.0.0
  • Replace local Prettier hook with remote repo at v3.6.2
  • Simplify prettier args to ['--write']
.pre-commit-config.yaml
Add tox to Python dev dependencies
  • Include tox>=4.30.3 in dev extras
pyproject.toml
Remove outdated build and lock files
  • Delete Dockerfile, package.json, package-lock.json, and uv.lock
Dockerfile
package.json
package-lock.json
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@eelcovv eelcovv self-assigned this Oct 3, 2025
@eelcovv
Copy link
Owner Author

eelcovv commented Oct 3, 2025

fix coverage token

@eelcovv eelcovv merged commit 9cb4570 into eelcovv:main Oct 3, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants