Support more than one instance #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binds the necessary DOM nodes for events instead of using selectors. This way, each instance of the color picker is encapsulated and changes won't affect other instances of the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binds the necessary DOM nodes for events instead of using selectors. This way, each instance of the color picker is encapsulated and changes won't affect other instances of the component.
Before
Unpredictable behavior
https://user-images.githubusercontent.com/18432482/151742321-b3bc867a-6fb7-4c04-913e-e479db58a8b7.mp4
After
Works as expected
https://user-images.githubusercontent.com/18432482/151742384-aad516b5-af0f-4ee1-99d0-e1eefdc0fcad.mp4