Conversation
Agent-Logs-Url: https://github.com/loebpaul/freshdesk_mcp/sessions/3bb4458d-8a62-46a9-9d9c-ff445bb94f47 Co-authored-by: loebpaul <5465651+loebpaul@users.noreply.github.com>
Add knowledge base delete and search tools
There was a problem hiding this comment.
Pull request overview
Adds missing Freshdesk Solutions (knowledge base) API coverage by introducing delete tools for articles/folders/categories and a search tool for solution articles, completing CRUD coverage for these resources.
Changes:
- Added
delete_solution_article,delete_solution_folder, anddelete_solution_categoryMCP tools handling HTTP 204 success. - Added
search_solution_articles(term, page, per_page)MCP tool returning an{articles, pagination}envelope parsed from theLinkheader. - Extended
tests/test-fd-mcp.pywith manual async functions exercising the new tools.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/freshdesk_mcp/server.py |
Implements new Solutions delete + article search MCP tools, including pagination parsing. |
tests/test-fd-mcp.py |
Adds manual test helpers/imports for the new tools. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… canned responses, and fields Agent-Logs-Url: https://github.com/loebpaul/freshdesk_mcp/sessions/9af5c6b8-85d1-4eec-88a6-077d2e8f9b5e Co-authored-by: loebpaul <5465651+loebpaul@users.noreply.github.com>
Add missing CRUD tools across contacts, companies, agents, groups, canned responses, and fields
…e tests, add unit tests Agent-Logs-Url: https://github.com/loebpaul/freshdesk_mcp/sessions/102c57c8-c42d-4cb3-86b3-5a4bed954752 Co-authored-by: loebpaul <5465651+loebpaul@users.noreply.github.com>
Agent-Logs-Url: https://github.com/loebpaul/freshdesk_mcp/sessions/102c57c8-c42d-4cb3-86b3-5a4bed954752 Co-authored-by: loebpaul <5465651+loebpaul@users.noreply.github.com>
Address review feedback on PR effytech#45: fix imports, guard destructive tests, add unit tests
|
Addresses the three review comments: Changes1. Fix Added a SRC_DIR = Path(__file__).resolve().parents[1] / "src"
if str(SRC_DIR) not in sys.path:
sys.path.insert(0, str(SRC_DIR))The import now uses 2. Guard destructive tests behind The three 3. Add mocked-httpx unit tests ( New test file with 11 tests covering:
|
Several entities were missing create/update/delete coverage, leaving the MCP server without full CRUD capability. Contacts and companies had no write operations beyond update; agents, groups, canned responses, and field types all lacked delete. The Solutions (knowledge base) API coverage was missing delete operations for all three resource levels and article search, leaving full CRUD incomplete.
Added tools
Contacts
create_contact()— requires at least one ofemail,phone,mobile,twitter_iddelete_contact()Companies
create_company()— requiresnameupdate_company()delete_company()Agents / Groups
delete_agent()delete_group()Canned Responses & Folders
delete_canned_response()delete_canned_response_folder()Fields
delete_contact_field()delete_ticket_field()Solutions
delete_solution_article(article_id)delete_solution_folder(folder_id)delete_solution_category(category_id)search_solution_articles(term, page, per_page)Search returns the standard
{"articles": [...], "pagination": {...}}envelope.All delete tools handle
204 No Contentexplicitly and return structured error dicts on failure, consistent with the existing delete implementations (e.g.delete_solution_article).