OwnableValidator with better API and without the linked list #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version I've added a
updateConfigmethod that looks like this:function updateConfig(uint256 newThreshold, address[] calldata ownersToAdd, address[] calldata ownersToRemove)A UI that has a section to manage your signers is likely to have some component where users can do the following operations:
It makes sense to just provide the UI dev with an API that can take all of these things in one go, and not have to worry about mid-batch reverts due to ordering of operations as you do with the batched transaction of the more primitive methods (addOwner, removeOwner, setThreshold). That said, this contract still has those methods too, if we ever want to use them.
** Technical stuff **
EnumerableSet4337instead ofSentinelList4337.prevto delete an entry)OwnableValidator.t.solfiles, and all tests are passing.(also, I think this implementation has much better structure/readability than the original one)