Add From<Symbol> implementation for Var #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to create your own domain-specific variables that interop with egg's engine. This PR aims to fix that by adding a
From<Symbol>implementation forVar.This enables custom parsers for patterns that define the string representation of a variable, for example many algebra systems use uppercase letters (e.g.
X + Y -> Y + X) to denote their variables. Currently egg only supports variables with a question mark prefix (e.g.?x,?#1).The only problem I can see this change creating is that it's no longer guaranteed that any variables used by egg have a
?prefix, but I don't think the code relies on this anywhere.