time limit support for impl LpExtractor #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The rust toolchain version was changed to 1.82 because indexmap 2.12.0 requires rustc 1.82. |
Contributor
Author
|
@mwillsey Forgot to do cargo fmt. |
Member
|
Hi @jk2997, this looks great. Is there a way to share code between the _with_timelimit functions and the ones without? The code looks almost identical. |
added 2 commits
November 26, 2025 19:42
Contributor
Author
|
@mwillsey I tried to refactor the code while retaining the two options of solving with a timeout and without a timeout. |
Member
|
Great, thanks for the contribution! |
Contributor
Author
|
@mwillsey Could you also update the crate version of egg? The research team that I am part of is working on integrating egg into an FPGA technology mapping tool called EqMap, and this time limit modification is useful to us (https://github.com/cornell-zhang/eqmap/tree/good_lp). |
Member
|
Done!
…On Wed, Dec 3, 2025 at 3:59 PM jk2997 ***@***.***> wrote:
*jk2997* left a comment (egraphs-good/egg#363)
<#363 (comment)>
@mwillsey <https://github.com/mwillsey> Could you also update the crate
version of egg? The research team that I am part of is working on
integrating egg into an FPGA technology mapping tool called EqMap, and this
time limit modification is useful to us (
https://github.com/cornell-zhang/eqmap/tree/good_lp).
—
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANTPTBLULUNQCRVWVU6VQL3752ODAVCNFSM6AAAAACL3LV622VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBZGMZDQNJVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
good_lp has a WithTimeLimit trait implemented for structs CoinCbcProblem and HighsProblem that allows the user to set a time limit for CBC and HiGHS (https://docs.rs/good_lp/latest/good_lp/solvers/trait.WithTimeLimit.html). Could there be alternate versions of solve_with() and solve_multiple_with() methods in impl LpExtractor that allow the egg library user to set timeouts if they are using LP extraction? If you could review my code, it would be greatly appreciated.