Conversation
added 2 commits
July 12, 2017 21:11
Collaborator
Author
|
@PeterJCLaw I've hacked the tests into passing, but at what cost? There's a skipped test, and some of the images have changed. Most of the images have changed how the text is rendered: pay attention to the letter 'a' All of the azteccode and datamatrix barcodes have changed significantly, why? I don't know. |
Contributor
|
Hrm, if the visuals have changed I wonder if there's some dependent font we're missing? |
Contributor
|
It might also be interesting to rewind the history to see if there was a point when they did pass. |
Collaborator
Author
|
Edit, I got the tests passing locally, but it looks like it's different on Travis. Probably fonts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.