Add clang-tidy suppression for InsertingVisitor reference members using NOLINTBEGIN/NOLINTEND blocks

[Copilot]

This PR addresses clang-tidy warnings about reference members in the InsertingVisitor struct. The warnings were flagged by the cppcoreguidelines-avoid-const-or-ref-data-members check.

Changes Made

Added a targeted suppression using NOLINTBEGIN/NOLINTEND blocks to both reference members with an explanatory comment:

struct InsertingVisitor {
  // NOLINTBEGIN(cppcoreguidelines-avoid-const-or-ref-data-members): Lifetime of referenced objects is guaranteed beyond visitor lifetime in this pattern
  JEvent& m_event;
  const std::string& m_collection_name;
  // NOLINTEND(cppcoreguidelines-avoid-const-or-ref-data-members)
  // ...
};

Justification

The NOLINTBEGIN/NOLINTEND block approach is preferred over inline NOLINT comments because it provides format-stable suppression that isn't dependent on line positioning, preventing issues when code formatters reflow long comment lines.

Both reference members are safe in this specific usage pattern because:

1. The InsertingVisitor is created and used immediately within the same scope in GetEvent()
2. The referenced objects (event and coll_name) come from the calling context and have guaranteed lifetimes that extend beyond the visitor's usage
3. The visitor is destroyed at the end of the loop iteration, well before the referenced objects go out of scope

This follows the established pattern in the codebase for suppressing specific clang-tidy warnings with appropriate justification comments.

Fixes #1981.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[wdconinc]

@copilot Please include the JEvent reference in the NOLINT block :-)

[Copilot]

@copilot Please include the JEvent reference in the NOLINT block :-)

Included the JEvent reference in the NOLINT block. Both reference members are now covered by the same suppression block. (commit: 8a0857e)

No Clang-Tidy warnings found so I assume my comments were addressed

[github-actions]

Capybara summary for PR 2031

• rec_dis_10x100_minQ2=0_craterlake_10x100
• rec_dis_10x100_minQ2=1000_craterlake_tracking_only
• rec_dis_18x275_minQ2=0_craterlake_18x275
• rec_dis_18x275_minQ2=0_craterlake_18x275_MT
• rec_dis_18x275_minQ2=0_craterlake_18x275_ST_MT
• rec_dis_18x275_minQ2=1000_craterlake_18x275
• rec_dis_18x275_minQ2=1000_craterlake_18x275_MT
• rec_dis_18x275_minQ2=1000_craterlake_18x275_ST_MT
• rec_dis_5x41_minQ2=0_craterlake_5x41
• rec_e_1GeV_20GeV_craterlake
• rec_pi_1GeV_20GeV_craterlake
  ^{_{Last updated 2025-08-22T14:54-04:00 60d01a7}}