-
Notifications
You must be signed in to change notification settings - Fork 50
MPGD Geo Validation #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MPGD Geo Validation #930
Conversation
@mposik1983 It seems like the tracking geometry check is complaining about some overlaps. Do you see it locally as well? https://github.com/eic/epic/actions/runs/17614403464/job/50043978042?pr=930 |
apparently should be fixed by an acts update which is not on cvmfs yet. I checked on my local nightly and it seemed fine. One thing that remains now is the material map check. |
07e4b06
to
19dacbd
Compare
Rebased to trigger new set of workflows with the (finally) updated eic_xl on cvmfs. |
for more information, see https://pre-commit.ci
remove indentation
e8f4445
to
edbc56c
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Briefly, what does this PR introduce?
Check that MPGD simulation geometry matches CAD drawing (CAD File)
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Doesn't break anything, but geometry is changed and material map will need to be reproduced.
Does this PR change default behavior?
MPGD hit positions will be modified due to geometry changes