fix: resolved comment checkmark toggles the card again (fixes #268)

[jedrazb]

Summary

Regression in 0.0.34: clicking the checkmark of a resolved comment in the sidebar did not re-open the comment card. Reported in #268.

Root cause

The cursor-based sidebar expansion refactor (#244) moved expansion state to the parent (DocxEditor), driven by PagedEditor.onSelectionChange. But PagedEditor.updateSelectionOverlay() fires that callback from six call sites — transactions, view-ready, font-load, a ResizeObserver on the container, a [layout] effect, and HiddenPM's selection-change path. Four of those fire even when PM state hasn't changed.

Click flow for the resolved checkmark:

1. Click the marker — onMouseDown stops propagation, so the PM cursor does not move.
2. onClick → toggleExpand → setExpandedSidebarItem('comment-X').
3. Sidebar re-renders with the expanded CommentCard → container size changes.
4. ResizeObserver fires → updateSelectionOverlay → onSelectionChange(from, to) with the unchanged cursor.
5. The handler re-runs cursor-mark detection. Cursor is outside the comment range, so cursorSidebarItem = null → setExpandedSidebarItem(null).
6. Card collapses back to the checkmark within a frame — looks like the click did nothing.

Fix

Dedup at the source by PM state identity in updateSelectionOverlay:

if (lastNotifiedStateRef.current !== state) {
  lastNotifiedStateRef.current = state;
  onSelectionChangeRef.current?.(from, to);
}

PM states are immutable, so reference equality is the canonical "nothing changed" signal — covers selection, doc, and stored-marks changes in one check. Overlay geometry redraw still runs; only the public callback is guarded.

Why this over a consumer-side guard in DocxEditor:

• Every consumer of onSelectionChange benefits (toolbar sync, cursor-mark detection, user onSelectionChange prop), not just the sidebar branch.
• Reference equality catches stored-marks-only changes (Cmd+B on empty selection) that a (from, to) compare would wrongly skip.
• The public callback finally matches its name — it only fires on real selection / doc / marks changes.

Tests

New e2e/tests/comments-sidebar.spec.ts — 11 scenarios across three groups:

• cursor-based expansion (3): entering/leaving a comment range, multi-comment, keyboard navigation
• resolve / reopen regression Resolved comments are not visible on editor after resolving #268 (5): clicking the checkmark, expansion surviving multiple frames, toggle-back-to-checkmark, reopen flow, multi-resolved rendering
• feedback-loop stability (3): no self-collapse, resize-during-expansion (the smoking gun — fails without the dedup, verified by stashing), card click doesn't move the PM cursor

Also adds data-comment-id / data-comment-resolved attributes to ResolvedCommentMarker for reliable test targeting, and registers the new suite in CLAUDE.md so future PRs touching UnifiedSidebar / sidebar/** / updateSelectionOverlay run it.

Test plan

• bun run typecheck clean
• All 11 comments-sidebar.spec.ts tests pass
• resize while a resolved card is expanded does not collapse it fails on main without the dedup (verified by stashing PagedEditor.tsx and re-running)
• CI green
• Manual repro from Resolved comments are not visible on editor after resolving #268: add comment → resolve → click elsewhere → click checkmark → card re-expands with Reopen button visible

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docx-editor	Ready	Preview, Comment	Apr 16, 2026 10:08am