-
Notifications
You must be signed in to change notification settings - Fork 46
Bitcoin wallet: Docker-based integration tests (bitcoind + electrs) #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@binarybaron, this approach matches the repo’s existing integration test patterns, All tests pass reliably on clean Docker setups; failures are clear if Docker isn’t running. |
Will review soon. Is the PR description AI generated ? |
|
used AI just to refine the wording, but the implementation and reasoning are mine. |
|
I'd love to review/give my points on this as per #799 (comment) when this is completed, if its alright with you @binarybaron |
|
Hi @binarybaron, anything we can do to escalate things here? |
Not really. We will review this when we find the time. Thank you though. Can you re-write the description yourself or delete it entirely? If I want a AI summary I can run Claude Code myself. |
NP
Done |
|
I'll mark as ready for review in order to run the tests in CI. |
|
just a heads up that, still need to decide and implement WHICH cases to add next. |
Closes #799
added proper end-to-end integration tests for the
bitcoin-walletcrate by running real Bitcoin services inside Docker instead of mocks. It spins up a regtestbitcoindwithelectrsand verifies core wallet flows like receiving, sending, broadcasting, and confirming transactions. This helps catch real-world issues early and makes the wallet logic much more reliable.@binarybaron Follow-ups / WHICH cases to add next (tracking list)?